Summary: | [Qt] Crash on application exit after constructing and destroying a QWebView twice | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kari Salminen <kari.salminen> | ||||||||||||
Component: | Platform | Assignee: | Alexis Menard (darktears) <menard> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, menard, webkit.review.bot | ||||||||||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Kari Salminen
2011-02-08 07:10:16 PST
Created attachment 81824 [details]
Test case that builds
Crash: I set as P1. I can reproduce everytime with trunk on Linux. Backtrace: #0 0x0000000000000000 in ?? () #1 0x00007ffff703522c in WebCore::SharedTimerQt::~SharedTimerQt() () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #2 0x00007ffff7035289 in WebCore::SharedTimerQt::~SharedTimerQt() () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #3 0x00007ffff7035147 in WebCore::SharedTimerQt::qt_metacall(QMetaObject::Call, int, void**) () from /home/ikipou/dev/webkit/qtwebkit/WebKitBuild/Release/lib/libQtWebKit.so.4 #4 0x00007ffff514bfaf in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) () from /home/ikipou/dev/qt-oslo-staging-2_release_64/lib/libQtCore.so.4 #5 0x00007ffff513a5a3 in QCoreApplication::exec() () from /home/ikipou/dev/qt-oslo-staging-2_release_64/lib/libQtCore.so.4 #6 0x0000000000400e18 in main () Created attachment 82035 [details]
patch
Patch.
Comment on attachment 82035 [details]
patch
This really needs an autotest.
Created attachment 82310 [details]
Patch with test case
Attachment 82310 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2824: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 82310 [details] Patch with test case View in context: https://bugs.webkit.org/attachment.cgi?id=82310&action=review > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2823 > + for (int i = 0; i < 2; ++i) Coding style, { on this line. > Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2831 > + webView->load(QUrl(QLatin1String("http://www.google.com/"))); > + mainWindow.show(); > + connect(webView, SIGNAL(loadFinished(bool)), &mainWindow, SLOT(close())); > + QApplication::instance()->exec(); We can't rely on external websites in our autotests. Created attachment 82311 [details]
Patch v2 with comments taken into accounts...
Comment on attachment 82311 [details] Patch v2 with comments taken into accounts... View in context: https://bugs.webkit.org/attachment.cgi?id=82311&action=review LGTM > Source/WebCore/ChangeLog:8 > + Check the value is valid before use it. Nit: "Check IF.." The commit-queue encountered the following flaky tests while processing attachment 82311 [details]: fast/history/history-subframe-with-name.html bug 51039 (author: mihaip@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 82311 [details] Patch v2 with comments taken into accounts... Clearing flags on attachment: 82311 Committed r78490: <http://trac.webkit.org/changeset/78490> All reviewed patches have been landed. Closing bug. |