Bug 53962

Summary: [GTK] EventSender.keyDown does not support non-array modifier arguments
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Martin Robinson 2011-02-07 16:41:13 PST 
This can be seem by the failure of fast/forms/legend-access-key.html which uses "altKey" as the modifier argument.
Comment 1 Martin Robinson 2011-02-07 18:03:13 PST 
Created attachment 81560 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-07 23:43:12 PST 
Comment on attachment 81560 [details]
Patch

Very nice.  Nice use of a helper function.
Comment 3 Martin Robinson 2011-02-08 07:57:28 PST 
Comment on attachment 81560 [details]
Patch

Clearing flags on attachment: 81560

Committed r77936: <http://trac.webkit.org/changeset/77936>
Comment 4 Martin Robinson 2011-02-08 07:57:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2012-09-17 15:59:22 PDT 
This looks wrong. This is just a mistake in a single test.

Eric, you reviewed this. How did you decide that this change was OK?
Comment 6 Eric Seidel (no email) 2012-09-17 16:08:45 PDT 
Donno.  I mean, the option seems reasonable to me.  Checking if the arg is a string vs. array seems like a totally reasonable API convenience.  But if you feel strongly, I'm sure it can be removed.