| Summary: | Move the sputnik test suite out of fast/js/ | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ap, dglazkov, hyatt, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2011-02-07 15:16:22 PST
Created attachment 81541 [details]
Patch
I'm not sure what will happen when I try to land this. git diff --stat shows: 22196 files changed, 730747 insertions(+), 730728 deletions(-) Attachment 81541 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/test_expectations.txt:1984: Path does not exist. sputnik [test/expectations] [2]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
It looks like webkit-patch upload didn't include the file move metadata, so of course the style checker isn't aware of the new patch. I'm guessing that uploading base versions of all the moved files would explode something anyway so it's probably for the best. Comment on attachment 81541 [details]
Patch
Thanks for the review. cq-'ing it since this will likely take a bit of manual trickery to land.
Amazingly this just worked. http://trac.webkit.org/changeset/77885 |