Bug 53954

Summary: Move the sputnik test suite out of fast/js/
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+, jamesr: commit-queue-

James Robinson
Reported 2011-02-07 15:16:22 PST
Move the sputnik test suite out of fast/js/
Attachments
Patch (40.47 KB, patch)
2011-02-07 15:21 PST, James Robinson 		mitz: review+
jamesr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-02-07 15:21:23 PST
Created attachment 81541 [details] Patch
James Robinson
Comment 2 2011-02-07 15:21:58 PST
I'm not sure what will happen when I try to land this. git diff --stat shows: 22196 files changed, 730747 insertions(+), 730728 deletions(-)
WebKit Review Bot
Comment 3 2011-02-07 15:23:15 PST
Attachment 81541 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:1984: Path does not exist. sputnik [test/expectations] [2] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
James Robinson
Comment 4 2011-02-07 15:46:38 PST
It looks like webkit-patch upload didn't include the file move metadata, so of course the style checker isn't aware of the new patch. I'm guessing that uploading base versions of all the moved files would explode something anyway so it's probably for the best.
James Robinson
Comment 5 2011-02-07 16:57:39 PST
Comment on attachment 81541 [details] Patch Thanks for the review. cq-'ing it since this will likely take a bit of manual trickery to land.
James Robinson
Comment 6 2011-02-07 20:02:01 PST
Amazingly this just worked. http://trac.webkit.org/changeset/77885
Note You need to log in before you can comment on or make changes to this bug.