Summary: | Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||
Component: | WebKit2 | Assignee: | Brian Weinstein <bweinstein> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bweinstein, mjs, pfeldman, sam, sullivan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp?rev=77713#L184 | ||||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-02-07 08:45:19 PST
The code has moved to WKBundlePageResourceLoadClient::willSendRequestForFrame, but the bug still exists. :-( Created attachment 84822 [details]
[PATCH] Fix
This change broke WK2 layout tests (existing early after 20 crashes). Do you want to roll it out? (In reply to comment #5) > This change broke WK2 layout tests (existing early after 20 crashes). Do you want to roll it out? It looks like the issue is I didn't touch WebKitTestRunner. I'm looking into a fix now. Created attachment 84871 [details]
[PATCH] Crash fix
Comment on attachment 84871 [details] [PATCH] Crash fix View in context: https://bugs.webkit.org/attachment.cgi?id=84871&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:348 > + WKRetain(returnedRequest); This is incorrect. The other willSendRequestForFrame should do the WKRetain. Created attachment 84872 [details]
[PATCH] crash Fix (Take 2)
Landed crash fix in r80427. |