Bug 53886

Summary: [EFL] Remove WebCore::currentTime()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, ryuan.choi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-02-06 11:53:44 PST
see patch
Attachments
Patch (1.46 KB, patch)
2011-02-06 11:58 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2011-02-19 04:20 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-06 11:58:01 PST
Created attachment 81423 [details] Patch
Ryuan Choi
Comment 2 2011-02-17 17:30:07 PST
add WebKit EFL reviewers/committers to CC. It looks OK to me.
Gyuyoung Kim
Comment 3 2011-02-17 17:35:48 PST
LGTM.
Antonio Gomes
Comment 4 2011-02-17 20:10:16 PST
Comment on attachment 81423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81423&action=review > Source/WebCore/ChangeLog:8 > + There is no declaration for it and we use WTF::currentTime() everywherey. typo: everywhereY. > Source/WebCore/platform/efl/SystemTimeEfl.cpp:2 > - * Copyright (C) 2008 INdT. All rights reserved. > - * Copyright (C) 2009-2010 ProFUSION embedded systems > - * Copyright (C) 2009-2010 Samsung Electronics > + * Copyright (C) 2009 Apple Inc. All Rights Reserved. Why this?
Patrick R. Gansterer
Comment 5 2011-02-19 04:20:25 PST
Created attachment 83069 [details] Patch (In reply to comment #4) > > Source/WebCore/ChangeLog:8 > > + There is no declaration for it and we use WTF::currentTime() everywherey. > > typo: everywhereY. Fixed. > > Source/WebCore/platform/efl/SystemTimeEfl.cpp:2 > > - * Copyright (C) 2008 INdT. All rights reserved. > > - * Copyright (C) 2009-2010 ProFUSION embedded systems > > - * Copyright (C) 2009-2010 Samsung Electronics > > + * Copyright (C) 2009 Apple Inc. All Rights Reserved. > > Why this? Now it's the same file as the other SystemTime*.cpp files of the other ports.
Patrick R. Gansterer
Comment 6 2011-02-19 07:54:49 PST
Comment on attachment 83069 [details] Patch Clearing flags on attachment: 83069 Committed r79122: <http://trac.webkit.org/changeset/79122>
Patrick R. Gansterer
Comment 7 2011-02-19 07:55:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.