Bug 53818 – MediaPlayerPrivateQTKit should use the Application Cache during load.

• Component: Media
• Status: RESOLVED FIXED

[Jer Noble]

Once https://bugs.webkit.org/show_bug.cgi?id=53784 lands, the MediaPlayerPrivateQTKit should query the Application Cache for resources during load.

[Jer Noble]

<rdar://problem/9178011>

[Jer Noble]

Created attachment 86709 [details]
Patch

[Maciej Stachowiak]

Comment on attachment 86709 [details]
Patch

r=me

[WebKit Review Bot]

Attachment 86709 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8235196

[Jer Noble]

The build failure is due to the dependant patch from Bug #53784 not being applied first.

[Eric Carlson]

Comment on attachment 86709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86709&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:319
> +    NSMutableDictionary *movieAttributes = [NSMutableDictionary dictionaryWithObjectsAndKeys:
> +        [NSNumber numberWithBool:m_player->preservesPitch()], QTMovieRateChangesPreservePitchAttribute,
> +        [NSNumber numberWithBool:YES], QTMoviePreventExternalURLLinksAttribute,
> +        [NSNumber numberWithBool:YES], QTSecurityPolicyNoCrossSiteAttribute,
> +        [NSNumber numberWithBool:NO], QTMovieAskUnresolvedDataRefsAttribute,
> +        [NSNumber numberWithBool:NO], QTMovieLoopsAttribute,
> +        [NSNumber numberWithBool:YES], @"QTMovieOpenForPlaybackAttribute",
> +#ifndef BUILDING_ON_TIGER
> +        QTMovieApertureModeClean, QTMovieApertureModeAttribute,
> +#endif
> +        nil];
> +    

I hate having code duplicated in multiple functions, can you put this into a function that you call from MediaPlayerPrivateQTKit::createQTMovie(const String&) and here?

[Jer Noble]

(In reply to comment #6)
> (From update of attachment 86709 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86709&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:319
> > +    NSMutableDictionary *movieAttributes = [NSMutableDictionary dictionaryWithObjectsAndKeys:
> > +        [NSNumber numberWithBool:m_player->preservesPitch()], QTMovieRateChangesPreservePitchAttribute,
> > +        [NSNumber numberWithBool:YES], QTMoviePreventExternalURLLinksAttribute,
> > +        [NSNumber numberWithBool:YES], QTSecurityPolicyNoCrossSiteAttribute,
> > +        [NSNumber numberWithBool:NO], QTMovieAskUnresolvedDataRefsAttribute,
> > +        [NSNumber numberWithBool:NO], QTMovieLoopsAttribute,
> > +        [NSNumber numberWithBool:YES], @"QTMovieOpenForPlaybackAttribute",
> > +#ifndef BUILDING_ON_TIGER
> > +        QTMovieApertureModeClean, QTMovieApertureModeAttribute,
> > +#endif
> > +        nil];
> > +    
> 
> I hate having code duplicated in multiple functions, can you put this into a function that you call from MediaPlayerPrivateQTKit::createQTMovie(const String&) and here?

Sure, except for the QTMovieOpenForPlaybackAttribute, which is conditional in createQTMovie.

[Jer Noble]

Committed r82009: <http://trac.webkit.org/changeset/82009>

[WebKit Review Bot]

http://trac.webkit.org/changeset/82009 might have broken Leopard Intel Release (Tests)
The following tests are not passing:
plugins/embed-prefers-plugins-for-images.html