Bug 53812

Summary: Remove duplication in test expectations for chromium media/ tests (in service of http://crbug.com/28993)
Product: WebKit Reporter: Ami Fischman <fischman>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Ami Fischman
Reported 2011-02-04 14:24:05 PST
Remove duplication in test expectations for chromium media/ tests (in service of http://crbug.com/28993)
Attachments
Patch (59.68 KB, patch)
2011-02-04 14:24 PST, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Patch (59.02 KB, patch)
2011-02-04 14:47 PST, Ami Fischman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ami Fischman
Comment 1 2011-02-04 14:24:53 PST
Created attachment 81285 [details] Patch
Ami Fischman
Comment 2 2011-02-04 14:47:19 PST
Created attachment 81290 [details] Patch
Eric Carlson
Comment 3 2011-02-04 15:30:19 PST
Comment on attachment 81290 [details] Patch Nice changes, thanks! I am marking this r+ but hesitate to give it a cq+ as it is Friday afternoon and as this kind of change *frequently* causes build breakage. Add a comment here or ping me on IRC if you are ready to babysit the tree tonight and I (or someone else) can cq+ it.
Ami Fischman
Comment 4 2011-02-04 22:34:20 PST
Thanks for the quick review, Eric, and thanks for holding off cq+ until monday morning. I'll be online and watching starting 9:30am pacific time.
WebKit Commit Bot
Comment 5 2011-02-07 21:40:14 PST
Comment on attachment 81290 [details] Patch Clearing flags on attachment: 81290 Committed r77893: <http://trac.webkit.org/changeset/77893>
WebKit Commit Bot
Comment 6 2011-02-07 21:40:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.