Bug 53812

Summary:

Remove duplication in test expectations for chromium media/ tests (in service of http://crbug.com/28993)

Product:

WebKit

Reporter:

Ami Fischman <fischman>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Ami Fischman 2011-02-04 14:24:05 PST

Remove duplication in test expectations for chromium media/ tests (in service of http://crbug.com/28993)

Comment 1 Ami Fischman 2011-02-04 14:24:53 PST

Created attachment 81285 [details]
Patch

Comment 2 Ami Fischman 2011-02-04 14:47:19 PST

Created attachment 81290 [details]
Patch

Comment 3 Eric Carlson 2011-02-04 15:30:19 PST

Comment on attachment 81290 [details]
Patch

Nice changes, thanks!

I am marking this r+ but hesitate to give it a cq+ as it is Friday afternoon and as this kind of change *frequently* causes build breakage. Add a comment here or ping me on IRC if you are ready to babysit the tree tonight and I (or someone else) can cq+ it.

Comment 4 Ami Fischman 2011-02-04 22:34:20 PST

Thanks for the quick review, Eric, and thanks for holding off cq+ until monday morning.  I'll be online and watching starting 9:30am pacific time.

Comment 5 WebKit Commit Bot 2011-02-07 21:40:14 PST

Comment on attachment 81290 [details]
Patch

Clearing flags on attachment: 81290

Committed r77893: <http://trac.webkit.org/changeset/77893>

Comment 6 WebKit Commit Bot 2011-02-07 21:40:18 PST

All reviewed patches have been landed.  Closing bug.