Bug 53780

Summary:

Crash log links in results.html should include the function that crashed on Mac

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Adam Roben (:aroben) 2011-02-04 09:46:29 PST

Crash log links in results.html should include the function that crashed on Mac

Comment 1 Adam Roben (:aroben) 2011-02-04 09:47:25 PST

Created attachment 81235 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2011-02-04 09:52:07 PST

Comment on attachment 81235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81235&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:2017
> +            $location = $functionAndOffset;

You should return "$module: $functionAndOffset" to match Windows here.

Comment 3 Adam Roben (:aroben) 2011-02-04 10:02:06 PST

Committed r77636: <http://trac.webkit.org/changeset/77636>