Bug 53779

Summary:

Remove last vestiges of JSVALUE32

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

JavaScriptCore

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ggaren, mrowe, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	darin: review+

David Kilzer (:ddkilzer)

Reported 2011-02-04 09:40:03 PST

Created attachment 81233 [details] Patch Reviewed by NOBODY (OOPS!). Support for JSVALUE32 was originaly removed in r70111. * Configurations/JavaScriptCore.xcconfig: Changed armv6 to use JavaScriptCore.JSVALUE32_64.exp and ppc64 to use JavaScriptCore.JSVALUE64.exp to match Platform.h. * DerivedSources.make: Removed rule for JavaScriptCore.JSVALUE32.exp. * JavaScriptCore.JSVALUE32only.exp: Removed. * JavaScriptCore.xcodeproj/project.pbxproj: Removed references to JavaScriptCore.JSVALUE32only.exp. --- 5 files changed, 19 insertions(+), 9 deletions(-)

Attachments
Patch (5.34 KB, patch) 2011-02-04 09:40 PST, David Kilzer (:ddkilzer)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2011-02-04 10:13:24 PST

Committed r77638: <http://trac.webkit.org/changeset/77638>

David Kilzer (:ddkilzer)

Comment 2 2011-02-04 13:11:02 PST

Clean build fix: (In reply to comment #1) > Committed r77638: <http://trac.webkit.org/changeset/77638> Build fix: Committed r77662: <http://trac.webkit.org/changeset/77662>

WebKit Review Bot

Comment 3 2011-02-04 17:28:38 PST

http://trac.webkit.org/changeset/77662 might have broken GTK Linux 32-bit Debug and GTK Linux 64-bit Debug The following tests are not passing: fast/blockflow/Kusa-Makura-background-canvas.html fast/blockflow/japanese-ruby-horizontal-bt.html fast/blockflow/japanese-ruby-vertical-lr.html fast/blockflow/japanese-ruby-vertical-rl.html fast/ruby/nested-ruby.html fast/text/emphasis-avoid-ruby.html

Note You need to log in before you can comment on or make changes to this bug.