Bug 53777

Summary:

Asynchronous client-based proposed implementation for the device element

Product:

WebKit

Reporter:

Leandro Graciá Gil <leandrogracia>

Component:

DOM

Assignee:

Leandro Graciá Gil <leandrogracia>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, adam.bergkvist, andreip, buildbot, jorlow, leandrogracia, mike, peter, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none
Class diagram of the proposed model.	none
Diagram for the local device successful connection/disconnection use case.	none
Patch	none

Leandro Graciá Gil

Reported 2011-02-04 09:31:00 PST

This is the implementation for our proposed design for the device element. This patch is not intended to be reviewed or directly submitted, but to be used to understand our proposal. If accepted, this is intended to be uploaded in a set of small, easy to review patches for which https://bugs.webkit.org/show_bug.cgi?id=53595 and https://bugs.webkit.org/show_bug.cgi?id=53776 should be the first and second one. ChangeLogs and the mock-related code have been left out of this patch.

Attachments
Patch (120.91 KB, patch) 2011-02-04 09:41 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Class diagram of the proposed model. (35.60 KB, application/pdf) 2011-02-04 13:29 PST, Leandro Graciá Gil	no flags	Details
Diagram for the local device successful connection/disconnection use case. (49.75 KB, application/pdf) 2011-02-09 13:09 PST, Leandro Graciá Gil	no flags	Details
Patch (132.79 KB, patch) 2011-02-09 13:10 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Leandro Graciá Gil

Comment 1 2011-02-04 09:41:00 PST

Created attachment 81234 [details] Patch

WebKit Review Bot

Comment 2 2011-02-04 09:44:35 PST

Attachment 81234 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/Configurations/Featu..." exit_code: 1 Source/WebCore/dom/DeviceConnection.h:76: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2011-02-04 10:55:19 PST

Attachment 81234 [details] did not build on win: Build output: http://queues.webkit.org/results/7694912

Leandro Graciá Gil

Comment 4 2011-02-04 13:29:43 PST

Created attachment 81277 [details] Class diagram of the proposed model.

Leandro Graciá Gil

Comment 5 2011-02-09 13:09:20 PST

Created attachment 81854 [details] Diagram for the local device successful connection/disconnection use case.

Leandro Graciá Gil

Comment 6 2011-02-09 13:10:15 PST

Created attachment 81855 [details] Patch

Build Bot

Comment 7 2011-02-09 15:13:19 PST

Attachment 81855 [details] did not build on win: Build output: http://queues.webkit.org/results/7884047

Note You need to log in before you can comment on or make changes to this bug.