Bug 53719

Summary:

new-run-webkit-tests: fix handling of port_names, options parsing

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, mihaip, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mihaip: review+

Dirk Pranke

Reported 2011-02-03 15:02:23 PST

new-run-webkit-tests: fix handling of port_names, options parsing

Attachments
Patch (9.50 KB, patch) 2011-02-03 15:07 PST, Dirk Pranke	mihaip: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2011-02-03 15:07:54 PST

Created attachment 81118 [details] Patch

Mihai Parparita

Comment 2 2011-02-03 15:45:11 PST

Comment on attachment 81118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81118&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:43 > + def test_get_chromium_gpu__on_linux(self): Nit: Did you really mean to have two underscores after gpu (same thing below).

Dirk Pranke

Comment 3 2011-02-03 15:46:48 PST

(In reply to comment #2) > (From update of attachment 81118 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81118&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:43 > > + def test_get_chromium_gpu__on_linux(self): > > Nit: Did you really mean to have two underscores after gpu (same thing below). Yes, I often try to do that to help distinguish the function or method being tested from some aspect of the test.

Dirk Pranke

Comment 4 2011-02-03 16:15:27 PST

Committed r77551: <http://trac.webkit.org/changeset/77551>

Note You need to log in before you can comment on or make changes to this bug.