Summary: | QuickTime plugin keeps playing audio after being destroyed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||
Component: | Plug-ins | Assignee: | Chris Blumenberg <cblu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | chris.giddings | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
mitz
2005-10-13 04:23:01 PDT
Created attachment 4340 [details]
testcase (uses external resource)
Created attachment 4360 [details]
stop and destroy plugin when removed
Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy)
to complying plugins right when they're removed from the WebHTMLView, and also
release them from the plugin controller's arrays.
I think this patch makes WebKit behave more like plugins expect it to, which is
the way it already behaves with Netscape plugins.
I expect complying plugins to stop making noise when receiving the stop
message, but QuickTime doesn't. If it's lucky, then it will be deallocated
because of the release and will stop then. However, JS, for one, can retain the
plugin (e.g. if you execute <javascript:document.getElementById('obj').width;>
before clicking Remove OBJECT), in which case it will just keep playing.
Comment on attachment 4360 [details]
stop and destroy plugin when removed
r=me
Tim Omernick landed the patch. |