Bug 53630

Summary: WebCore.gyp webcore_prerequisites needs some things moved into direct_dependent_settings
Product: WebKit Reporter: Mark Mentovai <mark>
Component: WebCore Misc.Assignee: Mark Mentovai <mark>
Severity: Normal CC: abarth, commit-queue, dglazkov, dpranke, eric, maruel, rsesek, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Fix v1
Fix v2 (no tabs)
Fix v3 (no nm -U) none

Description Mark Mentovai 2011-02-02 14:43:39 PST

Looks like this broke in r66364.
Comment 1 Mark Mentovai 2011-02-02 14:54:30 PST
Created attachment 80976 [details]
Fix v1

Chrome try runs in progress:


Note for checkin: WebCore/WebCore.gyp/mac/check_objc_rename.sh needs to have the executable bit set.
bash$ svn propset svn:executable '*' WebCore/WebCore.gyp/mac/check_objc_rename.sh
Comment 2 WebKit Review Bot 2011-02-02 14:56:25 PST
Attachment 80976 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/WebCore.gyp/WebCore.gyp:1025:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Mentovai 2011-02-02 15:10:17 PST
Created attachment 80977 [details]
Fix v2 (no tabs)
Comment 4 Mark Mentovai 2011-02-02 20:03:52 PST
Created attachment 81026 [details]
Fix v3 (no nm -U)

Apparently, nm -U (don’t display undefined symbols) is new in cctools 782 (Xcode 3.2.3). Chrome still needs to support 3.2.2 (and, for some real stragglers, 3.1.5), so the -U needs to go. This has no impact on the script, it’ll work just as well without -U.
Comment 5 Dimitri Glazkov (Google) 2011-02-03 08:48:57 PST
Comment on attachment 81026 [details]
Fix v3 (no nm -U)

Comment 6 WebKit Commit Bot 2011-02-03 16:46:45 PST
Comment on attachment 81026 [details]
Fix v3 (no nm -U)

Clearing flags on attachment: 81026

Committed r77562: <http://trac.webkit.org/changeset/77562>
Comment 7 WebKit Commit Bot 2011-02-03 16:46:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2011-02-03 17:03:34 PST
The commit-queue encountered the following flaky tests while processing attachment 81026 [details]:

http/tests/websocket/tests/handshake-challenge-randomness.html bug 53738 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 9 Dirk Pranke 2011-02-03 19:41:55 PST
I think this may have broken the mac build ...
Comment 10 Dirk Pranke 2011-02-03 19:59:34 PST
Committed r77589: <http://trac.webkit.org/changeset/77589>
Comment 11 Mark Mentovai 2011-02-03 21:17:06 PST
Dirk, can you please show me the Mac build break you encountered?
Comment 12 Mark Mentovai 2011-02-03 21:24:41 PST
OK, I found http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/18787. The errors in the build log:

PhaseScriptExecution "Postbuild \"Check Objective-C Rename\"" ../../WebKit/chromium/xcodebuild/WebCore.build/Release/webcore_html.build/Script-C80125C94888F34350BF52AA.sh
    cd /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp
    /bin/sh -c /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../../WebKit/chromium/xcodebuild/WebCore.build/Release/webcore_html.build/Script-C80125C94888F34350BF52AA.sh

/Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../../WebKit/chromium/xcodebuild/WebCore.build/Release/webcore_html.build/Script-C80125C94888F34350BF52AA.sh: line 2: /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/mac/check_objc_rename.sh: Permission denied
/Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../../WebKit/chromium/xcodebuild/WebCore.build/Release/webcore_html.build/Script-C80125C94888F34350BF52AA.sh: line 2: exec: /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/mac/check_objc_rename.sh: cannot execute: Unknown error: 0

and then

mark@rj bash$ svn proplist -v http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/WebCore.gyp/mac/check_objc_rename.sh@77562
mark@rj bash$ 

(as in “no properties set.”)

This looks like check_objc_rename.sh was checked in without the svn:executable property set as I recommended in comment 1. When I asked Dimitri to commit-queue this, I also asked whether the commit-queue supported setting svn:executable, and he said he didn’t know but there was only one way to find out. :)

The v3 patch from this patch set should be checked in manually, with the svn:executable property set properly on check_objc_rename.sh.
Comment 13 Dirk Pranke 2011-02-03 21:37:07 PST
Yup, that sounds like the problem. Thanks Mark! I imagine either Dimitri or I can land it manually in the morning.
Comment 14 WebKit Review Bot 2011-02-04 02:40:53 PST
http://trac.webkit.org/changeset/77562 might have broken GTK Linux 32-bit Debug and GTK Linux 64-bit Debug
The following tests are not passing:
Comment 15 Dimitri Glazkov (Google) 2011-02-04 08:52:06 PST
(In reply to comment #13)
> Yup, that sounds like the problem. Thanks Mark! I imagine either Dimitri or I can land it manually in the morning.

I don't have an svn checkout.
Comment 16 Mark Mentovai 2011-02-04 09:45:07 PST
It ought to be easy to pull an svn tree to check this in. I guess there’s no way to set svn properties from git?

Dirk, do you have a WebKit svn checkout handy?
Comment 17 Dirk Pranke 2011-02-04 10:17:32 PST
Yes, I do. I'll land it when I get into work in a little while.
Comment 18 Dirk Pranke 2011-02-04 13:12:39 PST
Committed r77663. <http://trac.webkit.org/changeset/77663>
Comment 19 WebKit Review Bot 2011-02-04 17:28:42 PST
http://trac.webkit.org/changeset/77663 might have broken GTK Linux 32-bit Debug and GTK Linux 64-bit Debug
The following tests are not passing: