Bug 53596

Summary:

[v8] Properly process exceptions thrown while converting objects to string in HTMLDocument.write{,ln} methods

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

WebCore Misc.

Assignee:

anton muhin <antonm>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

abarth, andersca, ap, arv, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

53601

Bug Blocks:

Attachments:

Description	Flags
Patch	none

anton muhin

Reported 2011-02-02 08:05:57 PST

[v8] Properly process exceptions thrown while converting objects to string in HTMLDocument.write{,ln} methods

Attachments
Patch (5.50 KB, patch) 2011-02-02 09:21 PST, anton muhin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2011-02-02 08:40:36 PST

This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends.

anton muhin

Comment 2 2011-02-02 09:21:23 PST

Created attachment 80920 [details] Patch

anton muhin

Comment 3 2011-02-02 09:22:14 PST

Comment on attachment 80920 [details] Patch Pending on https://bugs.webkit.org/show_bug.cgi?id=53601

David Levin

Comment 4 2011-02-02 09:57:56 PST

(In reply to comment #1) > This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 > > I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). > > I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends. fwiw, you could write a check in the style checker to catch this automatically (source at Tools/Scripts/webkitpy/style/checkers/cpp.py).

anton muhin

Comment 5 2011-02-02 09:59:36 PST

(In reply to comment #4) > (In reply to comment #1) > > This is a fix for 1st crash in http://code.google.com/p/chromium/issues/detail?id=71544 > > > > I am going to eventually nuke all unsafe uses of v8ValueToWebCoreString, but it require several patches )I think). > > > > I am going to make PSA asking v8 bindings hacking people do not use v8ValueToWebCoreString and friends. > > fwiw, you could write a check in the style checker to catch this automatically (source at Tools/Scripts/webkitpy/style/checkers/cpp.py). Very nice idea, David, thanks a lot. I'll do it if we decide to deprecate this behaviour.

Alexey Proskuryakov

Comment 6 2011-02-03 11:09:26 PST

Is this problem unique to v8, or does it also affect JSC?

Adam Barth

Comment 7 2011-02-03 11:16:52 PST

(In reply to comment #6) > Is this problem unique to v8, or does it also affect JSC? Presumably if the tests pass in JSC, it's not a problem in JSC.

anton muhin

Comment 8 2011-02-03 11:18:32 PST

This patch solves the issue with HTMLDocument::write and writeln not exiting quickly when first argument throwing an exception is met. So it's a solution for Chromium for https://bugs.webkit.org/show_bug.cgi?id=53601. And no, tests do not pass under Safari, again, see https://bugs.webkit.org/show_bug.cgi?id=53601 (In reply to comment #6) > Is this problem unique to v8, or does it also affect JSC?

Alexey Proskuryakov

Comment 9 2011-02-03 12:16:42 PST

I believe that we normally want bug to bug compatibility for such things, when possible.

anton muhin

Comment 10 2011-02-04 03:13:08 PST

(In reply to comment #9) > I believe that we normally want bug to bug compatibility for such things, when possible. That's precisely why I removed r? and marked this bug as blocked by https://bugs.webkit.org/show_bug.cgi?id=53601 :)

Anders Carlsson

Comment 11 2013-09-01 10:35:03 PDT

V8 is gone.

Note You need to log in before you can comment on or make changes to this bug.