Bug 5357

Summary:

REGRESSION: Scriptable plugin hides properties of OBJECT element

Product:

WebKit

Reporter:

mitz

Component:

JavaScriptCore

Assignee:

Geoffrey Garen <ggaren>

Status:

VERIFIED FIXED

Severity:

Major

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
testcase	none
proposed patch	mjs: review+

mitz

Reported 2005-10-12 15:49:22 PDT

A plugin that implements a scriptable object in ObjC can cause all properties of the OBJECT element containing it to be undefined. To reproduce: open the testcase in Safari. It tests for the children property not being undefined. This happens when the plugin does not respond to invokeUndefinedMethodFromWebScript:withArguments:.

Attachments
testcase (598 bytes, text/html) 2005-10-12 15:50 PDT, mitz	no flags	Details
proposed patch (911 bytes, patch) 2005-10-12 15:58 PDT, mitz	mjs: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2005-10-12 15:50:51 PDT

Created attachment 4330 [details] testcase

mitz

Comment 2 2005-10-12 15:58:51 PDT

Created attachment 4331 [details] proposed patch The bug resulted from the path for bug 4313, specifically the change in RuntimeObjectImp::getOwnPropertySlot. An alternative fix is to undo that change.

Darin Adler

Comment 3 2005-10-13 07:17:03 PDT

Comment on attachment 4331 [details] proposed patch I believe the underlying cause here is that Objective-C "undefined" values are not returned true to isUndefined(). I think we should fix that rather than applying this patch or undoing the change from bug 4313.

mitz

Comment 4 2005-10-19 00:08:52 PDT

Comment on attachment 4331 [details] proposed patch Asking Maciej to review this patch, after I talked with Darin.

Maciej Stachowiak

Comment 5 2005-10-25 22:24:10 PDT

Comment on attachment 4331 [details] proposed patch r=me

Note You need to log in before you can comment on or make changes to this bug.