Fix pink video bug with gpu-acceleration enabled

• Component: New Bugs
• Status: RESOLVED FIXED

[Victoria Kirst]

Fix pink video bug with gpu-acceleration enabled

[Victoria Kirst]

Created attachment 80876 [details]
Patch

[Kenneth Russell]

Comment on attachment 80876 [details]
Patch

We really should figure out a more general solution to this problem. Can we switch the locale of the GPU process to something neutral?

This workaround seems OK to me, but it's going to be fragile.

[Victoria Kirst]

Thanks Ken!

I agree, this is a weak solution. Evan Martin recently uploaded a patch to force LC_NUMERIC to C for all non-browser processes, which should also theoretically fix this. (http://codereview.chromium.org/6347045) But since that patch is a bit scary and should have some baking time before we commit to it, we thought it'd be best to upload this in interim to merge into m10.

[James Robinson]

Comment on attachment 80876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80876&action=review

> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:108
> +        "  gl_FragColor = vec4(rgb, float(1) * alpha;         \n"

these parens are mismatched (pointed out by someone on the crbug)

[Victoria Kirst]

Created attachment 81101 [details]
Patch

[Victoria Kirst]

Comment on attachment 81101 [details]
Patch

Oops, argh, screwed up change log...

[Victoria Kirst]

Created attachment 81102 [details]
Patch

[Victoria Kirst]

> these parens are mismatched (pointed out by someone on the crbug)

Yikes, thanks for the catch, jamesr/crbug guy!!

[Vangelis Kokkevis]

out of curiosity, would replacing 0.5 with (float)1/2 work?  It would touch less code...

[WebKit Commit Bot]

Comment on attachment 81102 [details]
Patch

Clearing flags on attachment: 81102

Committed r77608: <http://trac.webkit.org/changeset/77608>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.