Bug 53567

Summary: REGRESSION(r75982): [Chromium] Wrong popup position for RTL
Product: WebKit Reporter: Naoki Takano <honten>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, honten, tkent, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch
tkent: review-
Delete tabs
none
Delete tabs
none
Patch none

Description Naoki Takano 2011-02-01 18:51:27 PST 
[Chromium]Fix popup menu RTL bug introduced by Changeset 75982.
Comment 1 Naoki Takano 2011-02-01 19:00:03 PST 
Created attachment 80873 [details]
Patch
Comment 2 Naoki Takano 2011-02-01 19:00:38 PST 
Comment on attachment 80873 [details]
Patch

Could you review?
Comment 3 WebKit Review Bot 2011-02-01 19:02:45 PST 
Attachment 80873 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Kent Tamura 2011-02-01 19:09:44 PST 
Comment on attachment 80873 [details]
Patch

Please fix style errors.
The code looks good.
Comment 5 Naoki Takano 2011-02-02 00:11:38 PST 
Created attachment 80899 [details]
Delete tabs

My vim automatically inserted tabs.
I'll check my environment...
Comment 6 Naoki Takano 2011-02-02 00:12:38 PST 
Created attachment 80900 [details]
Delete tabs
Comment 7 Kent Tamura 2011-02-02 00:30:05 PST 
Comment on attachment 80900 [details]
Delete tabs

ok
Comment 8 WebKit Commit Bot 2011-02-02 00:50:52 PST 
Comment on attachment 80900 [details]
Delete tabs

Clearing flags on attachment: 80900

Committed r77370: <http://trac.webkit.org/changeset/77370>
Comment 9 WebKit Commit Bot 2011-02-02 00:50:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Naoki Takano 2011-02-11 00:36:11 PST 
Created attachment 82111 [details]
Patch
Comment 11 Naoki Takano 2011-02-11 00:38:00 PST 
Comment on attachment 82111 [details]
Patch

Tamaru-san,

Sorry for bothering you.

Could you review again?

As I wrote in ChangeLog, this is not good for the chrome bug http://codereview.chromium.org/6024008/

Thanks,
Comment 12 Kent Tamura 2011-02-13 17:48:11 PST 
Please don't make a committed patch obsolete.
Please file another bug.
Comment 13 Naoki Takano 2011-02-13 23:23:10 PST 
Ok,

(In reply to comment #12)
> Please don't make a committed patch obsolete.
> Please file another bug.