Bug 53535

Summary: Don't clear the callbacks ref in the proxy layer for IndexedDB
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, dgrogan, hans, japhet
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch japhet: review+

Jeremy Orlow
Reported 2011-02-01 14:28:08 PST
Don't clear the callbacks ref in the proxy layer for IndexedDB
Attachments
Patch (3.90 KB, patch)
2011-02-01 14:29 PST, Jeremy Orlow 		japhet: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2011-02-01 14:29:47 PST
Created attachment 80829 [details] Patch
Andrei Popescu
Comment 2 2011-02-01 18:15:54 PST
> learing the callbacks doesn't actually solve any problems and makes > this code behave subtly differently than how it would in Safari and > other single process environments. Let's remove the difference. Rather than this, I'd explicitly say what are the differences (especially since they are subtle :))
Jeremy Orlow
Comment 3 2011-02-01 18:21:41 PST
(In reply to comment #2) > > learing the callbacks doesn't actually solve any problems and makes > > this code behave subtly differently than how it would in Safari and > > other single process environments. Let's remove the difference. > > Rather than this, I'd explicitly say what are the differences (especially since they are subtle :)) The differences are in the timing of when stuff gets freed. Which is significant because ActiveDOMObjects can't be freed at certain points.
Jeremy Orlow
Comment 4 2011-02-03 17:19:53 PST
Committed r77572: <http://trac.webkit.org/changeset/77572>
Note You need to log in before you can comment on or make changes to this bug.