Summary: | Modify the style check script to allow parameter names if they share the same type | ||
---|---|---|---|
Product: | WebKit | Reporter: | Zhenyao Mo <zmo> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | levin |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 |
Description
Zhenyao Mo
2011-02-01 10:17:10 PST
Some tips: The file to modify is Tools/Scripts/webkitpy/style/checkers/cpp.py The function which loops over the variables and does the check is check_function_definition. Right now _check_parameter_name_against_text is the function which does the error message on a per parameter basis, but that will have to change to do this fix. The unit test is in Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py Look for the function test_parameter_names |