|Summary:||Remove global variable $httpdPath and replace with the return value of getHTTPDPath().|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||commit-queue, dbates, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description sccameron 2011-02-01 09:04:49 PST
There is a getHTTPDPath() function in httpd.pm that is only used once. In other cases, a global $httpdPath variable is used. I propose removing the global $httpdPath variable and using local calls to getHTTPDPath() instead.
Comment 2 sccameron 2011-02-01 09:30:10 PST
Created attachment 80771 [details] tab was present in changelog and added link to this bug
Comment 3 WebKit Review Bot 2011-02-01 11:53:28 PST
Attachment 80764 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-iexp..." exit_code: 1 Tools/ChangeLog:6: Line contains tab character. [whitespace/tab]  Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Seidel (no email) 2011-04-06 10:23:16 PDT
Comment on attachment 80771 [details] tab was present in changelog and added link to this bug We don't use "get" in method names generally.
Comment 5 Eric Seidel (no email) 2011-04-06 10:23:50 PDT
Comment on attachment 80771 [details] tab was present in changelog and added link to this bug Ah, but I guess you didn't add this method.
Comment 6 WebKit Commit Bot 2011-04-06 18:37:43 PDT
Comment on attachment 80771 [details] tab was present in changelog and added link to this bug Clearing flags on attachment: 80771 Committed r83129: <http://trac.webkit.org/changeset/83129>
Comment 7 WebKit Commit Bot 2011-04-06 18:37:46 PDT
All reviewed patches have been landed. Closing bug.