Summary: | Remove global variable $httpdPath and replace with the return value of getHTTPDPath(). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | sccameron | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dbates, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
sccameron
2011-02-01 09:04:49 PST
Created attachment 80764 [details]
use getHTTPDPath()
Created attachment 80771 [details]
tab was present in changelog and added link to this bug
Attachment 80764 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-iexp..." exit_code: 1
Tools/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 80771 [details]
tab was present in changelog and added link to this bug
We don't use "get" in method names generally.
Comment on attachment 80771 [details]
tab was present in changelog and added link to this bug
Ah, but I guess you didn't add this method.
Comment on attachment 80771 [details] tab was present in changelog and added link to this bug Clearing flags on attachment: 80771 Committed r83129: <http://trac.webkit.org/changeset/83129> All reviewed patches have been landed. Closing bug. |