Bug 53499

Summary:

Remove global variable $httpdPath and replace with the return value of getHTTPDPath().

Product:

WebKit

Reporter:

sccameron

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
use getHTTPDPath()	none
tab was present in changelog and added link to this bug	none

sccameron

Reported 2011-02-01 09:04:49 PST

There is a getHTTPDPath() function in httpd.pm that is only used once. In other cases, a global $httpdPath variable is used. I propose removing the global $httpdPath variable and using local calls to getHTTPDPath() instead.

Attachments
use getHTTPDPath() (3.07 KB, patch) 2011-02-01 09:06 PST, sccameron	no flags	Details Formatted Diff Diff
tab was present in changelog and added link to this bug (3.18 KB, patch) 2011-02-01 09:30 PST, sccameron	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

sccameron

Comment 1 2011-02-01 09:06:36 PST

Created attachment 80764 [details] use getHTTPDPath()

sccameron

Comment 2 2011-02-01 09:30:10 PST

Created attachment 80771 [details] tab was present in changelog and added link to this bug

WebKit Review Bot

Comment 3 2011-02-01 11:53:28 PST

Attachment 80764 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-iexp..." exit_code: 1 Tools/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 4 2011-04-06 10:23:16 PDT

Comment on attachment 80771 [details] tab was present in changelog and added link to this bug We don't use "get" in method names generally.

Eric Seidel (no email)

Comment 5 2011-04-06 10:23:50 PDT

Comment on attachment 80771 [details] tab was present in changelog and added link to this bug Ah, but I guess you didn't add this method.

WebKit Commit Bot

Comment 6 2011-04-06 18:37:43 PDT

Comment on attachment 80771 [details] tab was present in changelog and added link to this bug Clearing flags on attachment: 80771 Committed r83129: <http://trac.webkit.org/changeset/83129>

WebKit Commit Bot

Comment 7 2011-04-06 18:37:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.