Bug 53492

Summary: Web Inspector: Remove the *2 suffix from the CSS style-related protocol methods
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, commit-queue, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested solution pfeldman: review+, commit-queue: commit-queue-

Alexander Pavlov (apavlov)
Reported 2011-02-01 07:11:54 PST
We've got a bunch of InspectorBackend.get/set...2() calls, and the "2" suffix is obsolete.
Attachments
[PATCH] Suggested solution (30.25 KB, patch)
2011-02-01 07:53 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-02-01 07:53:03 PST
Created attachment 80760 [details] [PATCH] Suggested solution
WebKit Commit Bot
Comment 2 2011-02-01 09:56:06 PST
Comment on attachment 80760 [details] [PATCH] Suggested solution Rejecting attachment 80760 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2 Last 500 characters of output: ................................................................................................................................................................................... inspector ...................................................................... inspector/styles-source-lines-inline.html -> failed Exiting early after 1 failures. 18122 tests run. 386.77s total testing time 18121 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 8 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/7681769
Alexander Pavlov (apavlov)
Comment 3 2011-02-03 05:05:15 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/styles-iframe.html M LayoutTests/inspector/styles-new-API.html M LayoutTests/inspector/styles-source-lines-inline.html M LayoutTests/inspector/styles-source-lines.html M LayoutTests/inspector/styles-source-offsets.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/Inspector.idl M Source/WebCore/inspector/InspectorCSSAgent.cpp M Source/WebCore/inspector/InspectorCSSAgent.h M Source/WebCore/inspector/front-end/AuditRules.js M Source/WebCore/inspector/front-end/CSSStyleModel.js Committed r77478
WebKit Review Bot
Comment 4 2011-02-03 05:56:42 PST
http://trac.webkit.org/changeset/77478 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.