Bug 53482

Summary: Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Suggested fix none

Description Alexander Pavlov (apavlov) 2011-02-01 04:09:17 PST 
1. Open a web page with a background image.
2. Open the Developers Tools.
3. Select the DOM element with the background image.
4. Right click on the image link in the right panel.

What is the expected result?
Item with text: "Open link in new tab"

What happens instead?
Item with text: "Open Link in New Window"
Comment 1 Alexander Pavlov (apavlov) 2011-02-01 05:50:35 PST 
Created attachment 80750 [details]
[PATCH] Suggested fix
Comment 2 Yury Semikhatsky 2011-02-01 06:10:04 PST 
Comment on attachment 80750 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=80750&action=review

> Source/WebKit/chromium/src/js/DevTools.js:98
> +WebInspector.openLinkExternallyLabel = function()

Why not use the same mechanism in Chrome and in Safari?
Comment 3 WebKit Commit Bot 2011-02-01 06:53:28 PST 
Comment on attachment 80750 [details]
[PATCH] Suggested fix

Clearing flags on attachment: 80750

Committed r77249: <http://trac.webkit.org/changeset/77249>
Comment 4 WebKit Commit Bot 2011-02-01 06:53:33 PST 
All reviewed patches have been landed.  Closing bug.