Bug 53472

Summary:

Clean up ShadowBlur

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Simon Fraser (smfr)

Reported 2011-01-31 21:05:58 PST

Clean up ShadowBlur

Attachments
Patch (14.20 KB, patch) 2011-01-31 21:10 PST, Simon Fraser (smfr)	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2011-01-31 21:10:39 PST

Created attachment 80714 [details] Patch

Sam Weinig

Comment 2 2011-01-31 21:18:01 PST

Comment on attachment 80714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80714&action=review > Source/WebCore/platform/graphics/ShadowBlur.cpp:427 > + shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f), ColorSpaceDeviceRGB); This doesn't need to use the float Color constructor anymore. > Source/WebCore/platform/graphics/ShadowBlur.cpp:487 > + shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f), ColorSpaceDeviceRGB); Nor here.

Simon Fraser (smfr)

Comment 3 2011-01-31 21:20:17 PST

http://trac.webkit.org/changeset/77213

Simon Fraser (smfr)

Comment 4 2011-01-31 21:33:37 PST

And http://trac.webkit.org/changeset/77215

Note You need to log in before you can comment on or make changes to this bug.