Summary: | Using Control-C to cancel webkit-patch or other python tools causes unpleasant traceback console spew | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, mihaip, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Darin Adler
2011-01-31 15:57:42 PST
We could catch these, sure. For now we've enjoyed the default handler's print-the-stacktrace behavior. Since I’m using the scripts, not developing them, the traceback is never useful to me. Yes, I think you are correct that these scripts have moved from a development stage to being deployed and used and we should get rid of debug messages like these. I agree with this bug completely. Created attachment 80793 [details]
Patch
Comment on attachment 80793 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80793&action=review > Tools/Scripts/webkit-patch:72 > + pass Exiting with a non-0 exit code seems better (see http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#L440) Created attachment 80797 [details]
Patch
Comment on attachment 80797 [details]
Patch
I would hav elogged "user interupted". I might even put this in the multicommandtool.py instead.
Also, isn't there a python helper for the 128 + bit?
I don't think this should exit 0 though, so you're right in returning the signal code.
Comment on attachment 80797 [details] Patch Clearing flags on attachment: 80797 Committed r77275: <http://trac.webkit.org/changeset/77275> All reviewed patches have been landed. Closing bug. |