|Summary:||[Qt][WK2]REGRESSION (r76991): Fix build errors|
|Product:||WebKit||Reporter:||Csaba Osztrogonác <ossy>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abecsi, andersca, kbalazs, laszlo.gombos, sam|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Csaba Osztrogonác 2011-01-30 10:59:15 PST
31 #ifdef __cplusplus 32 #define new ("if you use new/delete make sure to include config.h at the top of the file"()) 33 #define delete ("if you use new/delete make sure to include config.h at the top of the file"()) This change caused build error in moc_qwkhistory.cpp and moc_qwkpage.cpp . These files are generated from qwkhistory.h and qwkpage.h by Qt's moc and they only inlcude its own header file. To fix this build break I added including config.h to these headers: http://trac.webkit.org/changeset/77088 I know we shouldn't include config.h in headers, but I don't know if it is possible to make moc add including config.h to moc_[...].cpp files. I leave this bug open to find a correct solution for this build break.
Comment 1 Csaba Osztrogonác 2011-01-30 11:16:56 PST
Comment 2 Balazs Kelemen 2011-01-30 11:50:20 PST
Comment 4 Balazs Kelemen 2011-01-30 12:25:43 PST
Comment on attachment 80597 [details] Patch Clearing flags on attachment: 80597 Committed r77092: <http://trac.webkit.org/changeset/77092>
Comment 5 Balazs Kelemen 2011-01-30 12:25:50 PST
All reviewed patches have been landed. Closing bug.