Bug 53383

Summary: Add WKPageCopyPendingURL API; returns the last URL requested for load via API before reaching provisional state
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Description Maciej Stachowiak 2011-01-29 14:47:48 PST
Add WKPageCopyPendingURL API; returns the last URL requested for load via API before reaching provisional state
Comment 1 Maciej Stachowiak 2011-01-29 14:52:01 PST
Created attachment 80577 [details]
Patch
Comment 2 Maciej Stachowiak 2011-01-29 20:04:31 PST
Created attachment 80585 [details]
Patch
Comment 3 Geoffrey Garen 2011-01-29 20:53:17 PST
Comment on attachment 80585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80585&action=review

The distinction between the dual concepts of "pending" and "provisional" is very subtle here. You should consider giving the two more distinctive names in the future.

I want to make a suggestion, but I'm not sure exactly why a requested URL doesn't immediately enter the provisional state.

r=me

> Source/WebKit2/ChangeLog:6
> +        Add WKPageCopyPendingURL API; returns the last URL requested for load via API before reaching provisional state
> +        https://bugs.webkit.org/show_bug.cgi?id=53383

I had a hard time parsing this sentence. I think you mean, "returns the last API-requested URL even if that URL hasn't reached the provisional state yet."
Comment 4 Maciej Stachowiak 2011-01-30 00:30:35 PST
Committed r77085: <http://trac.webkit.org/changeset/77085>