Bug 53373

Summary:

[Qt] Button Element is rendered w/ text off-center.

Product:

WebKit

Reporter:

lindem <timo.lindemann>

Component:

Layout and Rendering

Assignee:

Caio Marcelo de Oliveira Filho <cmarcelo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

420+

Hardware:

OS:

Linux

Attachments:

Description	Flags
html that exhibits the behaviour.	none
Screenshot.	none
proposed fix...	none

lindem

Reported 2011-01-29 01:18:11 PST

Created attachment 80555 [details] html that exhibits the behaviour. The example form is visible on http://buntebytes.de/~lindem/button-element.png (screenshot, comparison w/ input element, which is rendered correctly). The revision I am experiencing this with is qt 4.7.1 on Arch Linux. That'd be QtWebKit 2.0, but I don't really know which version to choose in the report form. The html is attached. Testing on windows, if I get around doing it today.

Attachments
html that exhibits the behaviour. (318 bytes, text/html) 2011-01-29 01:18 PST, lindem	no flags	Details
Screenshot. (3.51 KB, image/png) 2011-01-29 11:53 PST, lindem	no flags	Details
proposed fix... (1.15 KB, patch) 2011-02-18 14:47 PST, Dawit A.	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

lindem

Comment 1 2011-01-29 11:53:50 PST

Created attachment 80569 [details] Screenshot.

Benjamin Poulain

Comment 2 2011-01-29 12:29:59 PST

Looks related to #50521

lindem

Comment 3 2011-01-30 05:07:24 PST

Just wanted to comment that yasterday evening, on a suggestion from benjaminp in #qtwekbit, it's been revealed that html like <button> Text </button> causes the erroneous behaviour, while <button>Text</button> (note the absence of newlines inside the button element) does not.

Caio Marcelo de Oliveira Filho

Comment 4 2011-02-18 12:24:41 PST

It seems that in RenderThemeQt::adjustButtonStyle() there's a call to style->setWhiteSpace(PRE) that shouldn't be there. I can't see the reason why Button should have special treatment for whitespaces. This layout test agrees with me LayoutTests/fast/forms/button-white-space.html

Dawit A.

Comment 5 2011-02-18 14:47:35 PST

Created attachment 83013 [details] proposed fix... Patch based on comment #4 where it is correctly pointed out that setting a button's whitespace handling to PRE does not make sense and most definitely causes this bug in addition to violating the button with white-space layout test.

Andreas Kling

Comment 6 2011-02-18 19:47:47 PST

Comment on attachment 83013 [details] proposed fix... r=me

WebKit Commit Bot

Comment 7 2011-02-18 23:21:15 PST

The commit-queue encountered the following flaky tests while processing attachment 83013 [details]: http/tests/websocket/tests/handshake-challenge-randomness.html bug 53738 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 8 2011-02-18 23:23:10 PST

Comment on attachment 83013 [details] proposed fix... Clearing flags on attachment: 83013 Committed r79103: <http://trac.webkit.org/changeset/79103>

WebKit Commit Bot

Comment 9 2011-02-18 23:23:13 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 10 2011-02-21 01:59:53 PST

This patch fixed 3 tests on Qt. See http://trac.webkit.org/changeset/79198 for details.

Note You need to log in before you can comment on or make changes to this bug.