Bug 53353

Summary:

build-webkit gives a bogus warning with newer versions of Xcode

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrowe, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mrowe: review+

David Kilzer (:ddkilzer)

Reported 2011-01-28 16:29:40 PST

Created attachment 80523 [details] Patch Reviewed by NOBODY (OOPS!). * Scripts/webkitdirs.pm: (checkRequiredSystemConfig): Check the Xcode marketing version in addition to the DevCoreTools build version before complaining about an old version of Xcode. Also make the Mac OS X version check use Perl's built-in version string comparitor. --- 2 files changed, 19 insertions(+), 3 deletions(-)

Attachments
Patch (2.38 KB, patch) 2011-01-28 16:29 PST, David Kilzer (:ddkilzer)	mrowe: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2011-01-28 16:52:21 PST

Committed r77028: <http://trac.webkit.org/changeset/77028>

David Kilzer (:ddkilzer)

Comment 2 2011-01-28 16:53:50 PST

Added bug link to ChangeLog: Committed r77030: <http://trac.webkit.org/changeset/77030>

Note You need to log in before you can comment on or make changes to this bug.