Bug 53317

Summary:

Space not necessary for undefined feature

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ddkilzer: review+

Pratik Solanki

Reported 2011-01-28 11:49:30 PST

Following line in build-webkit defines feature as a space (" "). This can cause build failures in future. 408 return $feature . "=" . ($isEnabled ? $feature : " "); We should remove the space.

Attachments
Patch (30.50 KB, patch) 2011-01-28 11:57 PST, Pratik Solanki	ddkilzer: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pratik Solanki

Comment 1 2011-01-28 11:57:53 PST

Created attachment 80472 [details] Patch

David Kilzer (:ddkilzer)

Comment 2 2011-01-28 12:03:45 PST

Comment on attachment 80472 [details] Patch r=me

Pratik Solanki

Comment 3 2011-01-28 12:28:28 PST

Committed r76971: <http://trac.webkit.org/changeset/76971>

Pratik Solanki

Comment 4 2011-01-28 12:36:49 PST

Accidental .swp file check removed in http://trac.webkit.org/changeset/76973

Note You need to log in before you can comment on or make changes to this bug.