Bug 53317

Summary:

Space not necessary for undefined feature

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Pratik Solanki 2011-01-28 11:49:30 PST

Following line in build-webkit defines feature as a space (" "). This can cause build failures in future.

408         return $feature . "=" . ($isEnabled ? $feature : " ");

We should remove the space.

Comment 1 Pratik Solanki 2011-01-28 11:57:53 PST

Created attachment 80472 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2011-01-28 12:03:45 PST

Comment on attachment 80472 [details]
Patch

r=me

Comment 3 Pratik Solanki 2011-01-28 12:28:28 PST

Committed r76971: <http://trac.webkit.org/changeset/76971>

Comment 4 Pratik Solanki 2011-01-28 12:36:49 PST

Accidental .swp file check removed in http://trac.webkit.org/changeset/76973