| Summary: | Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 80440 [details]
[PATCH] Suggested fix
Comment on attachment 80440 [details] [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=80440&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1944 > + if (!selection.isCollapsed || !selection.rangeCount) Let's ignore the selection and always change suffix of the current word. Created attachment 80442 [details]
[PATCH] Comment addressed
Comment on attachment 80442 [details] [PATCH] Comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=80442&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1941 > + _selectSuffix: function() I'd give this method a more specific name. Landed with the method renamed. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/StylesSidebarPane.js Committed r76941 |
1. Create a property, "border: 1px solid" 2. Start editing the value, place the caret after "s" (in "solid"). 3. Press Up You will see "saddlebrownolid", "addlebrown" selected. Instead, the suffix ("olid") should get removed.