Bug 53292

Summary: [GTK] Fix compilation warning
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed patch
xan.lopez: review-
Proposed patch xan.lopez: review+

Description Alejandro G. Castro 2011-01-28 02:39:48 PST 
After r75955 we need to cast the number of pages:

../../../Source/WebKit/gtk/webkit/webkitwebframe.cpp: En la función ‘void draw_page_callback(GtkPrintOperation*, GtkPrintContext*, gint, void*)’:
../../../Source/WebKit/gtk/webkit/webkitwebframe.cpp:771:44: aviso: comparación entre expresiones enteras signed y unsigned
Comment 1 Alejandro G. Castro 2011-01-28 02:55:06 PST 
Created attachment 80434 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-01-28 03:58:56 PST 
Attachment 80434 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/7646102
Comment 3 Xan Lopez 2011-01-28 04:08:50 PST 
Comment on attachment 80434 [details]
Proposed patch

You are missing the opening '(' it seems.
Comment 4 Alejandro G. Castro 2011-01-28 04:14:55 PST 
Created attachment 80437 [details]
Proposed patch

Uploaded the wrong patch sorry.
Comment 5 Xan Lopez 2011-01-28 04:41:46 PST 
Comment on attachment 80437 [details]
Proposed patch

r=me
Comment 6 Alejandro G. Castro 2011-01-28 06:36:06 PST 
Landed http://trac.webkit.org/changeset/76940