Bug 53269
| Summary: | http://www.webglearth.com/ is grayscale in Safari, color in Firefox | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | WebGL | Assignee: | Kenneth Russell <kbr> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, cmarrin, kbr, simon.fraser, zmo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
| URL: | http://www.webglearth.com/ | ||
Simon Fraser (smfr)
http://www.webglearth.com/ is grayscale on Mac, in WebKit. In Firefox it's in color. This seems like a bug.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
That's strange. It probably has something to do with which image loaders are being used. It appears in color in Chromium and grayscale in Safari. I'll take a closer look.
Kenneth Russell
The CGImageRef coming back from ImageSource::createFrameAtIndex (ImageSourceCG.cpp) thinks that it's 8 bits per pixel. I'm stumped so far why this is happening only for the images on this site. Most WebGL content using textures (including PNG textures like this site) displays properly.
Kenneth Russell
The issue is that the PNGs loaded by this application are indexed, and the CG image loading path for WebGL doesn't handle them properly. See https://bugs.webkit.org/show_bug.cgi?id=47477 .
Chris Marrin
So then shouldn't this be marked a dup of that? Or is there more to it than just handling indexed PNG correctly?
Kenneth Russell
(In reply to comment #4)
> So then shouldn't this be marked a dup of that? Or is there more to it than just handling indexed PNG correctly?
I'll close it as a dup shortly. Patch forthcoming for the other bug.
Kenneth Russell
The patch for https://bugs.webkit.org/show_bug.cgi?id=47477 , which is currently out for review, fixes this problem.
*** This bug has been marked as a duplicate of bug 47477 ***