Bug 53252 – Split MediaControls out of RenderMedia.

• Component: New Bugs
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

Split MediaControls out of RenderMedia.

[Dimitri Glazkov (Google)]

Created attachment 80356 [details]
Patch

[Eric Carlson]

Comment on attachment 80356 [details]
Patch


  BRAVO!!

View in context: https://bugs.webkit.org/attachment.cgi?id=80356&action=review

> Source/WebCore/rendering/RenderMedia.cpp:-106
> -MediaPlayer* RenderMedia::player() const
> -{
> -    return mediaElement()->player();
> -}
> -

Why did you delete this function and update the call sites to use "mediaElement()->player()".

[Dimitri Glazkov (Google)]

Comment on attachment 80356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80356&action=review

>> Source/WebCore/rendering/RenderMedia.cpp:-106
>> -
> 
> Why did you delete this function and update the call sites to use "mediaElement()->player()".

No reason other than it wasn't used by this class. If you'd like, I can move it to RenderVideo instead?

[Eric Carlson]

(In reply to comment #3)
> (From update of attachment 80356 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80356&action=review
> 
> >> Source/WebCore/rendering/RenderMedia.cpp:-106
> >> -
> > 
> > Why did you delete this function and update the call sites to use "mediaElement()->player()".
> 
> No reason other than it wasn't used by this class. If you'd like, I can move it to RenderVideo instead?

Not necessary, I was just curious.

[Dimitri Glazkov (Google)]

Comment on attachment 80356 [details]
Patch

Please revert if it breaks stuff.

[WebKit Commit Bot]

Comment on attachment 80356 [details]
Patch

Rejecting attachment 80356 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
ile Source/WebCore/rendering/MediaControlElements.cpp
patching file Source/WebCore/rendering/RenderMedia.cpp
patching file Source/WebCore/rendering/RenderMedia.h
Hunk #3 FAILED at 62.
Hunk #4 succeeded at 77 (offset -2 lines).
1 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderMedia.h.rej
patching file Source/WebCore/rendering/RenderVideo.cpp

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7568372

[Dimitri Glazkov (Google)]

Committed r76950: <http://trac.webkit.org/changeset/76950>

[WebKit Review Bot]

http://trac.webkit.org/changeset/76950 might have broken Leopard Intel Release (Tests)