Bug 53251

Summary: CACFLayerTreeHost should use WKCACFView for rendering
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, jberlin, simon.fraser
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 31855, 39496    
Attachments:
Description Flags
Split CACFLayerTreeHost into base and derived classes
simon.fraser: review+
Move LegacyCACFLayerTreeHost into its own files
simon.fraser: review+
Add WKCACFViewLayerTreeHost simon.fraser: review+

Adam Roben (:aroben)
Reported 2011-01-27 11:07:23 PST
CACFLayerTreeHost should use the new WKCACFView API for rendering. This will reduce memory usage (bug 31855) and move rendering onto a non-main thread (bug 39496).
Attachments
Split CACFLayerTreeHost into base and derived classes (18.33 KB, patch)
2011-01-27 11:40 PST, Adam Roben (:aroben) 		simon.fraser: review+
DetailsFormatted DiffDiff
Move LegacyCACFLayerTreeHost into its own files (33.26 KB, patch)
2011-01-27 13:19 PST, Adam Roben (:aroben) 		simon.fraser: review+
DetailsFormatted DiffDiff
Add WKCACFViewLayerTreeHost (18.21 KB, patch)
2011-01-27 14:44 PST, Adam Roben (:aroben) 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-27 11:07:58 PST
<rdar://problem/8925496>
Adam Roben (:aroben)
Comment 2 2011-01-27 11:40:05 PST
Created attachment 80351 [details] Split CACFLayerTreeHost into base and derived classes
Adam Roben (:aroben)
Comment 3 2011-01-27 13:19:49 PST
Created attachment 80359 [details] Move LegacyCACFLayerTreeHost into its own files
Simon Fraser (smfr)
Comment 4 2011-01-27 13:29:53 PST
Comment on attachment 80351 [details] Split CACFLayerTreeHost into base and derived classes View in context: https://bugs.webkit.org/attachment.cgi?id=80351&action=review > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:213 > + bool m_mightBeAbleToCreateDeviceLater; > + COMPtr<IDirect3DDevice9> m_d3dDevice; > + WKCACFContext* m_context; > + Timer<LegacyCACFLayerTreeHost> m_renderTimer; > + bool m_mustResetLostDeviceBeforeRendering; Can you sort these to optimize padding? > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h:98 > CACFLayerTreeHostClient* m_client; > - bool m_mightBeAbleToCreateDeviceLater; > - COMPtr<IDirect3DDevice9> m_d3dDevice; > RefPtr<PlatformCALayer> m_rootLayer; > RefPtr<PlatformCALayer> m_rootChildLayer; > - WKCACFContext* m_context; > HWND m_window; > - Timer<CACFLayerTreeHost> m_renderTimer; > - bool m_mustResetLostDeviceBeforeRendering; > bool m_shouldFlushPendingGraphicsLayerChanges; > bool m_isFlushingLayerChanges; > HashSet<RefPtr<PlatformCALayer> > m_pendingAnimatedLayers; Ditto.
Simon Fraser (smfr)
Comment 5 2011-01-27 13:30:58 PST
Comment on attachment 80359 [details] Move LegacyCACFLayerTreeHost into its own files View in context: https://bugs.webkit.org/attachment.cgi?id=80359&action=review > Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:70 > + bool m_mightBeAbleToCreateDeviceLater; > + COMPtr<IDirect3DDevice9> m_d3dDevice; > + WKCACFContext* m_context; > + Timer<LegacyCACFLayerTreeHost> m_renderTimer; > + bool m_mustResetLostDeviceBeforeRendering; Put bools next to eachother.
Adam Roben (:aroben)
Comment 6 2011-01-27 14:44:12 PST
Created attachment 80366 [details] Add WKCACFViewLayerTreeHost
Adam Roben (:aroben)
Comment 7 2011-01-27 16:13:10 PST
Fixed in r76853, r76856, and r76858.
Jessie Berlin
Comment 8 2011-01-28 08:20:03 PST
These changes broke ~36 animations, compositing, and transitions tests on the Windows 7 Release bots: https://bugs.webkit.org/show_bug.cgi?id=53302
Note You need to log in before you can comment on or make changes to this bug.