Bug 53249

Summary:

Add ability to do an unconstrained scroll on a ScrollView

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, fishd, mihaip, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

55077

Attachments:

Description	Flags
Patch	hyatt: review+

Description Sam Weinig 2011-01-27 10:32:01 PST

Add ability to do an unconstrained scroll on a ScrollView

Comment 1 Sam Weinig 2011-01-27 10:36:50 PST

Created attachment 80346 [details]
Patch

Comment 2 Dave Hyatt 2011-01-27 10:43:24 PST

Comment on attachment 80346 [details]
Patch

Devirtualize the overhang painting function and get it out of FrameView, since ultimately it will be a callout through HostWindow.

r=me with that change.

Comment 3 Sam Weinig 2011-01-27 13:23:22 PST

Landed in r76831.

Comment 4 Eric Seidel (no email) 2011-01-27 13:29:56 PST

:(  Borked the whole world.

Comment 5 Eric Seidel (no email) 2011-01-27 13:31:28 PST

/Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/ScrollView.cpp: In member function 'void WebCore::ScrollView::paintOverhangAreas(WebCore::GraphicsContext*, const WebCore::IntRect&, const WebCore::IntRect&)':
/Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/ScrollView.cpp:928: error: 'context' was not declared in this scope
/Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/ScrollView.cpp:929: error: 'horizontalOverhangRect' was not declared in this scope
/Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/ScrollView.cpp:933: error: 'verticalOverhangRect' was not declared in this scope

Comment 6 WebKit Review Bot 2011-01-27 13:48:00 PST

http://trac.webkit.org/changeset/76831 might have broken Qt Linux Release