Bug 53233

Summary: [Qt][WK2] Lots of layout test failures due to wrong font type
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Description Balazs Kelemen 2011-01-27 02:35:42 PST
A bunch of layout tests failing in WTR because the default font types are differ in WK2 from WK1 and DRT.
The most frequent error is using Courier instead of Courier new as fixed font type.
The default values are being set in WebPreferencesStore.h. We should specialize them for Qt.
Comment 1 Balazs Kelemen 2011-01-27 04:11:26 PST
Created attachment 80317 [details]
Patch
Comment 2 Balazs Kelemen 2011-01-27 04:13:13 PST
The patch fixes 70 tests (tested on our wk2 bot: 
http://webkit.sed.hu/buildbot/waterfall?show=x86-32%20Linux%20Qt%20Release%20WebKit2)
Comment 3 Balazs Kelemen 2011-01-27 04:15:08 PST
(In reply to comment #2)
> The patch fixes 70 tests (tested on our wk2 bot: 
> http://webkit.sed.hu/buildbot/waterfall?show=x86-32%20Linux%20Qt%20Release%20WebKit2)

Ahm, this is not exactly true. The patch was tested on the same machine
that runs this bot.
Comment 4 Andreas Kling 2011-01-27 04:30:31 PST
Comment on attachment 80317 [details]
Patch

Delightful! r=me
Comment 5 Balazs Kelemen 2011-01-27 06:56:24 PST
Comment on attachment 80317 [details]
Patch

Clearing flags on attachment: 80317

Committed r76797: <http://trac.webkit.org/changeset/76797>
Comment 6 Balazs Kelemen 2011-01-27 06:56:30 PST
All reviewed patches have been landed.  Closing bug.