Bug 53207

Summary: [Chromium] Simplify small caps logic in complex text on linux
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: James Simonsen <simonjam>
Status: RESOLVED FIXED    
Severity: Normal CC: evan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tony: review+

James Simonsen
Reported 2011-01-26 17:18:04 PST
[Chromium] Simplify small caps logic in complex text on linux
Attachments
Patch (3.07 KB, patch)
2011-01-26 17:20 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (3.17 KB, patch)
2011-01-27 12:58 PST, James Simonsen 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2011-01-26 17:20:31 PST
Created attachment 80274 [details] Patch
James Simonsen
Comment 2 2011-01-27 10:56:40 PST
This should simplify things a bit.
Tony Chang
Comment 3 2011-01-27 11:05:41 PST
Comment on attachment 80274 [details] Patch The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future.
James Simonsen
Comment 4 2011-01-27 11:31:03 PST
(In reply to comment #3) > (From update of attachment 80274 [details]) > The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future. I think the existing one already covers that with "Lorem ipsum." I'm not sure why that didn't occur to me earlier. :/ We also cover the opposite condition with "A?b?e" in atsui-small-caps-punctuation-size.html. It's not entirely intuitive, but punctuation is considered to be upper case.
Tony Chang
Comment 5 2011-01-27 12:02:01 PST
Comment on attachment 80274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > Source/WebCore/ChangeLog:9 > + No new tests. > + Nit: Please mention which tests cover this.
James Simonsen
Comment 6 2011-01-27 12:58:19 PST
Created attachment 80358 [details] Patch
James Simonsen
Comment 7 2011-01-27 12:58:44 PST
(In reply to comment #5) > (From update of attachment 80274 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > > > Source/WebCore/ChangeLog:9 > > + No new tests. > > + > > Nit: Please mention which tests cover this. Done.
James Simonsen
Comment 8 2011-01-27 15:03:21 PST
Committed r76845: <http://trac.webkit.org/changeset/76845>
Note You need to log in before you can comment on or make changes to this bug.