| Summary: | [Chromium] Simplify small caps logic in complex text on linux | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Simonsen <simonjam> | ||||||
| Component: | New Bugs | Assignee: | James Simonsen <simonjam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | evan, tony | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
James Simonsen
2011-01-26 17:18:04 PST
Created attachment 80274 [details]
Patch
This should simplify things a bit. Comment on attachment 80274 [details]
Patch
The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future.
(In reply to comment #3) > (From update of attachment 80274 [details]) > The code looks good, but can you still add a test case where an uppercase run becomes lowercase (if one doesn't exist)? That way we won't regress this in the future. I think the existing one already covers that with "Lorem ipsum." I'm not sure why that didn't occur to me earlier. :/ We also cover the opposite condition with "A?b?e" in atsui-small-caps-punctuation-size.html. It's not entirely intuitive, but punctuation is considered to be upper case. Comment on attachment 80274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > Source/WebCore/ChangeLog:9 > + No new tests. > + Nit: Please mention which tests cover this. Created attachment 80358 [details]
Patch
(In reply to comment #5) > (From update of attachment 80274 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80274&action=review > > > Source/WebCore/ChangeLog:9 > > + No new tests. > > + > > Nit: Please mention which tests cover this. Done. Committed r76845: <http://trac.webkit.org/changeset/76845> |