Summary: | Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | DOM | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, eric.carlson, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 53136 | ||||||
Bug Blocks: | 53020 | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2011-01-26 13:33:33 PST
Created attachment 80228 [details]
Patch
Apologies that the patch doesn't apply. I'll resubmit to ews once bug 53190 and bug 53136 land and make sure I don't break stuff. Comment on attachment 80228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80228&action=review > Source/WebCore/rendering/MediaControlElements.cpp:96 > + RefPtr<RenderStyle> timelineContainerStyle = document()->styleSelector()->styleForElement(this, 0, true); > renderer()->setStyle(timelineContainerStyle); You should release the style to avoid a tiny bit of reference count churn or not use the local variable at all here. Attachment 80228 [details] did not build on mac: Build output: http://queues.webkit.org/results/7632211 Committed r77954: <http://trac.webkit.org/changeset/77954> |