Bug 53190

Summary: Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 53136    
Bug Blocks: 53020    
Attachments:
Description Flags
Patch darin: review+

Description Dimitri Glazkov (Google) 2011-01-26 13:33:33 PST
Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
Comment 1 Dimitri Glazkov (Google) 2011-01-26 13:44:21 PST
Created attachment 80228 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-01-26 13:56:55 PST
Apologies that the patch doesn't apply. I'll resubmit to ews once bug 53190 and bug 53136 land and make sure I don't break stuff.
Comment 3 Darin Adler 2011-01-26 16:44:55 PST
Comment on attachment 80228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80228&action=review

> Source/WebCore/rendering/MediaControlElements.cpp:96
> +        RefPtr<RenderStyle> timelineContainerStyle = document()->styleSelector()->styleForElement(this, 0, true);
>          renderer()->setStyle(timelineContainerStyle);

You should release the style to avoid a tiny bit of reference count churn or not use the local variable at all here.
Comment 4 WebKit Review Bot 2011-01-26 17:03:34 PST
Attachment 80228 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7632211
Comment 5 Dimitri Glazkov (Google) 2011-02-08 10:35:32 PST
Committed r77954: <http://trac.webkit.org/changeset/77954>