Bug 53185

Summary:

[chromium] revert r68310 because of race conditions detected by tsans

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dumi, levin, michaeln, phajdan.jr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Tony Chang

Reported 2011-01-26 12:17:26 PST

[chromium] revert r68310 because of race conditions detected by tsans

Attachments
Patch (40.04 KB, patch) 2011-01-26 12:18 PST, Tony Chang	no flags	Details Formatted Diff Diff
Patch (41.03 KB, patch) 2011-01-26 12:36 PST, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2011-01-26 12:18:20 PST

Created attachment 80221 [details] Patch

WebKit Review Bot

Comment 2 2011-01-26 12:22:52 PST

Attachment 80221 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:45: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:45: chromium_sqlite3_initialize_unix_sqlite3_file is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: The parameter name "vfs" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: chromium_sqlite3_fill_in_unix_sqlite3_file is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47: chromium_sqlite3_get_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:48: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:48: chromium_sqlite3_update_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:49: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:49: chromium_sqlite3_destroy_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:125: One space before end of line comments [whitespace/comments] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:155: Use 0 instead of NULL. [readability/null] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:173: unix_vfs is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 14 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tony Chang

Comment 3 2011-01-26 12:27:56 PST

Comment on attachment 80221 [details] Patch Fails to link: LINK(target) out/Release/DumpRenderTree out/Release/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_platform.a(SQLiteFileSystemChromiumPosix.o): In function `(anonymous namespace)::chromiumOpen(sqlite3_vfs*, char const*, sqlite3_file*, int, int*)': SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x13): undefined reference to `chromium_sqlite3_initialize_unix_sqlite3_file' SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x34): undefined reference to `chromium_sqlite3_get_reusable_file_handle' SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x68): undefined reference to `chromium_sqlite3_update_reusable_file_handle' SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0xcf): undefined reference to `chromium_sqlite3_fill_in_unix_sqlite3_file' SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0xe7): undefined reference to `chromium_sqlite3_destroy_reusable_file_handle' SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_Source_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_DC8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x140): undefined reference to `chromium_sqlite3_destroy_reusable_file_handle' collect2: ld returned 1 exit status make: *** [out/Release/DumpRenderTree] Error 1

WebKit Review Bot

Comment 4 2011-01-26 12:29:53 PST

Attachment 80221 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7600320

Tony Chang

Comment 5 2011-01-26 12:36:00 PST

Created attachment 80225 [details] Patch

WebKit Review Bot

Comment 6 2011-01-26 12:37:51 PST

Attachment 80225 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:45: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:45: chromium_sqlite3_initialize_unix_sqlite3_file is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: The parameter name "vfs" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:46: chromium_sqlite3_fill_in_unix_sqlite3_file is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:47: chromium_sqlite3_get_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:48: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:48: chromium_sqlite3_update_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:49: The parameter name "file" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:49: chromium_sqlite3_destroy_reusable_file_handle is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:125: One space before end of line comments [whitespace/comments] [5] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:155: Use 0 instead of NULL. [readability/null] [4] Source/WebCore/platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:173: unix_vfs is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 14 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tony Chang

Comment 7 2011-01-26 13:30:59 PST

Comment on attachment 80225 [details] Patch http://trac.webkit.org/changeset/76713

David Levin

Comment 8 2011-02-04 06:15:32 PST

This appears to be resolved so I'm marking it as such.

Note You need to log in before you can comment on or make changes to this bug.