Bug 53149

Summary: remove resize() check in DrawingBuffer
Product: WebKit Reporter: Mike Reed <reed>
Component: PlatformAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jamesr, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
fix for issue
none
fix for issue none

Mike Reed
Reported 2011-01-25 17:21:39 PST
DrawingBufer::reset() today checks if the new size is the same as its m_size, and if so, returns immediately. This does not match the semantics of <canvas>, which wants to clear its contents anytime the size is specified.
Attachments
fix for issue (1.89 KB, patch)
2011-01-25 17:30 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
fix for issue (2.09 KB, patch)
2011-01-25 17:34 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-01-25 17:30:03 PST
Created attachment 80148 [details] fix for issue
Mike Reed
Comment 2 2011-01-25 17:34:19 PST
Created attachment 80149 [details] fix for issue
Mike Reed
Comment 3 2011-01-25 17:34:45 PST
uploaded new patch with more detail in ChangeLog
James Robinson
Comment 4 2011-01-25 17:35:40 PST
Comment on attachment 80149 [details] fix for issue Looks good! R=me
WebKit Commit Bot
Comment 5 2011-01-25 18:13:11 PST
The commit-queue encountered the following flaky tests while processing attachment 80149 [details]: http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html bug 52016 (author: jchaffraix@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-01-25 18:13:52 PST
Comment on attachment 80149 [details] fix for issue Clearing flags on attachment: 80149 Committed r76658: <http://trac.webkit.org/changeset/76658>
WebKit Commit Bot
Comment 7 2011-01-25 18:13:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.