Bug 5313
| Summary: | date_object.cpp Win32 compatibility | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Haygood <jhaygood> |
| Component: | JavaScriptCore | Assignee: | Maciej Stachowiak <mjs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
Justin Haygood
Separate bug for localtime_r gmtime_r missing already missing.
This one is just a general "other things missing":
* snprintf. This is simply fixed by adding #define snprintf _snprintf to #if
WIN32 block at top
* tm.gmtoff struct entry.. This is a Sun / BSD thing I believe. Does Linux have
it? I know for one Windows doesn't have it. Could possibly be emulated for Windows.
* strftime on Windows expects a const tm*, but the tm being passed is a plain
old tm. My C++ skills aren't the best, but can it possibly be fixed by changing
tm to (const tm *)&t ?. But as I said, I'm not the best at C/C++ stuff like
indirections and references and pointers.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I think this has all been fixed by now, and more (the latest change for tm_gmtoff emulation is in bug 7107).