Bug 53124

Summary: [SKIA] Remove "current path" of GraphicsContext
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48516    
Attachments:
Description Flags
Patch
krit: review+, paroga: commit-queue-
Patch
none
Patch
none
Patch none

Description Patrick R. Gansterer 2011-01-25 13:56:03 PST 
nobody took care of this since december :-(
Comment 1 Patrick R. Gansterer 2011-01-25 14:03:15 PST 
Created attachment 80117 [details]
Patch
Comment 2 Dirk Schulze 2011-01-25 14:07:42 PST 
Comment on attachment 80117 [details]
Patch

r=me
Comment 3 Patrick R. Gansterer 2011-01-25 14:09:03 PST 
Comment on attachment 80117 [details]
Patch

Let's see if if compiles on EWS.
Comment 4 WebKit Review Bot 2011-01-25 14:19:38 PST 
Attachment 80117 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7518352
Comment 5 Patrick R. Gansterer 2011-01-25 14:23:56 PST 
Created attachment 80120 [details]
Patch

Setting r? only for EWS
Comment 6 WebKit Review Bot 2011-01-25 14:33:52 PST 
Attachment 80120 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7493346
Comment 7 Eric Seidel (no email) 2011-01-25 14:34:09 PST 
Comment on attachment 80120 [details]
Patch

As soon as the EWS bubbles show numbers, you can remove the ?.  You can also use queues.webkit.org/submit-to-ews to submit a patch directly w/o using r?
Comment 8 Patrick R. Gansterer 2011-01-25 14:51:37 PST 
Created attachment 80129 [details]
Patch
Comment 9 WebKit Review Bot 2011-01-25 15:06:11 PST 
Attachment 80129 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7574319
Comment 10 Patrick R. Gansterer 2011-01-25 15:16:05 PST 
Created attachment 80132 [details]
Patch
Comment 11 Andreas Kling 2011-01-26 06:17:53 PST 
Comment on attachment 80132 [details]
Patch

LGTM! <3
Comment 12 WebKit Commit Bot 2011-01-26 06:50:27 PST 
Comment on attachment 80132 [details]
Patch

Clearing flags on attachment: 80132

Committed r76688: <http://trac.webkit.org/changeset/76688>
Comment 13 WebKit Commit Bot 2011-01-26 06:50:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 14 Stephen White 2011-01-26 09:00:07 PST 
Awesome, thanks!
Comment 15 Stephen White 2011-01-26 09:06:25 PST 
Unfortunately, some of the image results are different since this change.  :(

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&master=ChromiumWebkit&tests=fast%2Fbackgrounds%2Fsize%2Fcontain-and-cover.html%2Cfast%2Fbackgrounds%2Fsvg-as-background-5.html%2Cfast%2Fimages%2Fanimated-svg-as-image.html

This seems surprising, since this should've been a no-op.  I'll look into this further later.