Bug 53124

Summary: [SKIA] Remove "current path" of GraphicsContext
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48516    
Attachments:
Description Flags
Patch
krit: review+, paroga: commit-queue-
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-01-25 13:56:03 PST
nobody took care of this since december :-(
Attachments
Patch (6.16 KB, patch)
2011-01-25 14:03 PST, Patrick R. Gansterer 		krit: review+
paroga: commit-queue-
DetailsFormatted DiffDiff
Patch (6.14 KB, patch)
2011-01-25 14:23 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2011-01-25 14:51 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2011-01-25 15:16 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-01-25 14:03:15 PST
Created attachment 80117 [details] Patch
Dirk Schulze
Comment 2 2011-01-25 14:07:42 PST
Comment on attachment 80117 [details] Patch r=me
Patrick R. Gansterer
Comment 3 2011-01-25 14:09:03 PST
Comment on attachment 80117 [details] Patch Let's see if if compiles on EWS.
WebKit Review Bot
Comment 4 2011-01-25 14:19:38 PST
Attachment 80117 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7518352
Patrick R. Gansterer
Comment 5 2011-01-25 14:23:56 PST
Created attachment 80120 [details] Patch Setting r? only for EWS
WebKit Review Bot
Comment 6 2011-01-25 14:33:52 PST
Attachment 80120 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7493346
Eric Seidel (no email)
Comment 7 2011-01-25 14:34:09 PST
Comment on attachment 80120 [details] Patch As soon as the EWS bubbles show numbers, you can remove the ?. You can also use queues.webkit.org/submit-to-ews to submit a patch directly w/o using r?
Patrick R. Gansterer
Comment 8 2011-01-25 14:51:37 PST
Created attachment 80129 [details] Patch
WebKit Review Bot
Comment 9 2011-01-25 15:06:11 PST
Attachment 80129 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7574319
Patrick R. Gansterer
Comment 10 2011-01-25 15:16:05 PST
Created attachment 80132 [details] Patch
Andreas Kling
Comment 11 2011-01-26 06:17:53 PST
Comment on attachment 80132 [details] Patch LGTM! <3
WebKit Commit Bot
Comment 12 2011-01-26 06:50:27 PST
Comment on attachment 80132 [details] Patch Clearing flags on attachment: 80132 Committed r76688: <http://trac.webkit.org/changeset/76688>
WebKit Commit Bot
Comment 13 2011-01-26 06:50:36 PST
All reviewed patches have been landed. Closing bug.
Stephen White
Comment 14 2011-01-26 09:00:07 PST
Awesome, thanks!
Stephen White
Comment 15 2011-01-26 09:06:25 PST
Unfortunately, some of the image results are different since this change. :( http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&master=ChromiumWebkit&tests=fast%2Fbackgrounds%2Fsize%2Fcontain-and-cover.html%2Cfast%2Fbackgrounds%2Fsvg-as-background-5.html%2Cfast%2Fimages%2Fanimated-svg-as-image.html This seems surprising, since this should've been a no-op. I'll look into this further later.
Note You need to log in before you can comment on or make changes to this bug.