Bug 53098

Summary: [GTK] Implement spin buttons for GTK+ 2.x
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cgarcia, eric, gustavo, webkit.review.bot, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch xan.lopez: review+

Martin Robinson
Reported 2011-01-25 10:35:20 PST
This bug tracks the implementation of spin buttons for GTK+ 2.x. This is required to unskip tests and have useable input type=number.
Attachments
Patch (28.42 KB, patch)
2011-01-25 10:47 PST, Martin Robinson 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-01-25 10:47:33 PST
Created attachment 80082 [details] Patch
Xan Lopez
Comment 2 2011-03-07 11:16:15 PST
Comment on attachment 80082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80082&action=review Not even going to try to figure it the spinbutton gymnastics are ok ;) > Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:641 > + expandedRect.setWidth(rect.width() + 2); Why inflateY but not inflateX?
Martin Robinson
Comment 3 2011-03-07 11:20:57 PST
(In reply to comment #2) > > Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:641 > > + expandedRect.setWidth(rect.width() + 2); > Why inflateY but not inflateX? I this case I believe that we want to make it 2 pixels longer, but not actually adjust the left-hand side of the rectangle at all.
Martin Robinson
Comment 4 2011-03-10 16:13:02 PST
Committed r80783: <http://trac.webkit.org/changeset/80783>
WebKit Review Bot
Comment 5 2011-03-10 17:33:43 PST
http://trac.webkit.org/changeset/80783 might have broken GTK Linux 32-bit Release
Note You need to log in before you can comment on or make changes to this bug.