Summary: | REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, buildbot, eric, gustavo, koivisto, oliver, simon.fraser, webkit-ews, webkit.review.bot, xan.lopez | ||||
Priority: | P1 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-01-24 21:37:47 PST
Regressed in http://trac.webkit.org/changeset/76177. Created attachment 80069 [details]
patch
Cache did not know about the subclass so failed to fully delete the items. Got rid of the subclass and moved the classes to separate files.
Attachment 80069 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/parser/SourceProviderCache.h:39: The parameter name "item" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/parser/SourceProvider.h:33: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 80069 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7513332 Attachment 80069 [details] did not build on qt: Build output: http://queues.webkit.org/results/7493340 Attachment 80069 [details] did not build on win: Build output: http://queues.webkit.org/results/7507325 http://trac.webkit.org/changeset/76611 (with some non-mac build fixes) http://trac.webkit.org/changeset/76611 might have broken Windows Release (Build) and Windows Debug (Build) |