Summary: | [GTK] Two tests crash after r76555 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | svillar, xan.lopez | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2011-01-24 18:01:28 PST
The issue here is that we are calling handle->start(...) unconditionally even if there is a scheduled failure. I believe we can remedy this problem by calling ::create instead of creating the handle manually. Should have a patch soon. Created attachment 80104 [details]
Patch
Comment on attachment 80104 [details]
Patch
Tests are no longer timing out I assume? =)
(In reply to comment #3) > (From update of attachment 80104 [details]) > Tests are no longer timing out I assume? =) Thanks for the review! Tests still do not timeout because 1. ResourceHandle::create does not call handle->start if there is a scheduled failure. 2. The Soup caller does not start the internal event loop if there is a scheduled failure. Committed r77343: <http://trac.webkit.org/changeset/77343> |