Bug 53054

Summary: texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

Zhenyao Mo
Reported 2011-01-24 17:49:26 PST
On desktop GL, if they don't match, no error will be generated; but in GLES, "the same constraints and errors apply to the TexSubImage commands' argument format and the internalformat of the texture array being respecified as apply to the format and internalformat arguments of its TexImage counterparts".
Attachments
Patch (8.52 KB, patch)
2011-01-27 16:30 PST, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
Patch (8.16 KB, patch)
2011-01-27 16:35 PST, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2011-01-27 16:30:25 PST
Created attachment 80375 [details] Patch
Zhenyao Mo
Comment 2 2011-01-27 16:35:37 PST
Created attachment 80376 [details] Patch
Kenneth Russell
Comment 3 2011-01-27 17:15:44 PST
Comment on attachment 80376 [details] Patch Looks good. Please add the test to the WebGL conformance suite.
Zhenyao Mo
Comment 4 2011-01-27 17:16:49 PST
This test is almost a duplication from one of the more/function/ test. Should we still add it?
Kenneth Russell
Comment 5 2011-01-27 17:21:16 PST
(In reply to comment #4) > This test is almost a duplication from one of the more/function/ test. Should we still add it? It would be better from a maintenance perspective if we tried to keep the WebGL layout tests a subset of the WebGL conformance tests in the Khronos repository. If this test is mostly a copy of one of the more/function/ tests, what about moving it into the conformance suite proper upstream?
Zhenyao Mo
Comment 6 2011-01-27 17:22:13 PST
You mean delete the more/ test and add this one?
Kenneth Russell
Comment 7 2011-01-27 17:23:24 PST
(In reply to comment #6) > You mean delete the more/ test and add this one? Yes.
Zhenyao Mo
Comment 8 2011-01-27 17:26:36 PST
Committed r76874: <http://trac.webkit.org/changeset/76874>
Note You need to log in before you can comment on or make changes to this bug.