Bug 52999 – Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Podivilov]

Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.

This is a second step of debugger api refactoring (see bug 52879).

[Pavel Podivilov]

Created attachment 79904 [details]
Patch.

[WebKit Review Bot]

Attachment 79904 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:61:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:64:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Podivilov]

Created attachment 79906 [details]
Fix style.

[Pavel Feldman]

Comment on attachment 79904 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79904&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:333
> +        InspectorBackend.setAllJavaScriptBreakpoints(allJavaScriptBreakpoints);

Why do we push JavaScript breakpoints to the backend?

[Pavel Podivilov]

(In reply to comment #4)
> (From update of attachment 79904 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79904&action=review
> 
> > Source/WebCore/inspector/front-end/BreakpointManager.js:333
> > +        InspectorBackend.setAllJavaScriptBreakpoints(allJavaScriptBreakpoints);
> 
> Why do we push JavaScript breakpoints to the backend?

Because JavaScript breakpoints are persisted in localStorage, and we have to sync them with backend when loading inspector.

[Pavel Feldman]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 79904 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=79904&action=review
> > 
> > > Source/WebCore/inspector/front-end/BreakpointManager.js:333
> > > +        InspectorBackend.setAllJavaScriptBreakpoints(allJavaScriptBreakpoints);
> > 
> > Why do we push JavaScript breakpoints to the backend?
> 
> Because JavaScript breakpoints are persisted in localStorage, and we have to sync them with backend when loading inspector.

I thought we agreed that there should be no explicit setAllJavaScriptBreakpoints method.

[Pavel Podivilov]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 79904 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=79904&action=review
> > > 
> > > > Source/WebCore/inspector/front-end/BreakpointManager.js:333
> > > > +        InspectorBackend.setAllJavaScriptBreakpoints(allJavaScriptBreakpoints);
> > > 
> > > Why do we push JavaScript breakpoints to the backend?
> > 
> > Because JavaScript breakpoints are persisted in localStorage, and we have to sync them with backend when loading inspector.
> 
> I thought we agreed that there should be no explicit setAllJavaScriptBreakpoints method.

In this change JavaScript breakpoints are separated from browser breakpoints to simplify further refactoring. Later we'll get rid of setAllBreakpoints protocol methods.

[Pavel Podivilov]

Committed r76581: <http://trac.webkit.org/changeset/76581>