Bug 52946

Summary:

Cleaned up some conservative marking code.

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
follow-up patch	none
Patch	none
Patch	ggaren: review+

Geoffrey Garen

Reported 2011-01-21 19:51:13 PST

Cleaned up some conservative marking code.

Attachments
Patch (16.02 KB, patch) 2011-01-21 19:59 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
follow-up patch (4.77 KB, patch) 2011-01-21 22:41 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (19.53 KB, patch) 2011-01-22 10:54 PST, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (19.53 KB, patch) 2011-01-22 10:59 PST, Geoffrey Garen	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2011-01-21 19:59:54 PST

Created attachment 79819 [details] Patch

WebKit Review Bot

Comment 2 2011-01-21 20:01:13 PST

Attachment 79819 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/MachineStackMarker.cpp:402: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MarkedSpace.h:222: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MarkedSpace.h:226: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Maciej Stachowiak

Comment 3 2011-01-21 20:18:33 PST

Comment on attachment 79819 [details] Patch r=me Up to you whether to obey the style checker's requests here.

Geoffrey Garen

Comment 4 2011-01-21 20:27:27 PST

Committed r76425: <http://trac.webkit.org/changeset/76425>

Geoffrey Garen

Comment 5 2011-01-21 22:41:30 PST

Created attachment 79829 [details] follow-up patch

Geoffrey Garen

Comment 6 2011-01-21 22:41:53 PST

Comment on attachment 79829 [details] follow-up patch rs=maciej