Bug 52946

Summary: Cleaned up some conservative marking code.
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
follow-up patch
none
Patch
none
Patch ggaren: review+

Description Geoffrey Garen 2011-01-21 19:51:13 PST
Cleaned up some conservative marking code.
Comment 1 Geoffrey Garen 2011-01-21 19:59:54 PST
Created attachment 79819 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-21 20:01:13 PST
Attachment 79819 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/MachineStackMarker.cpp:402:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/runtime/MarkedSpace.h:222:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/JavaScriptCore/runtime/MarkedSpace.h:226:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Maciej Stachowiak 2011-01-21 20:18:33 PST
Comment on attachment 79819 [details]
Patch

r=me

Up to you whether to obey the style checker's requests here.
Comment 4 Geoffrey Garen 2011-01-21 20:27:27 PST
Committed r76425: <http://trac.webkit.org/changeset/76425>
Comment 5 Geoffrey Garen 2011-01-21 22:41:30 PST
Created attachment 79829 [details]
follow-up patch
Comment 6 Geoffrey Garen 2011-01-21 22:41:53 PST
Comment on attachment 79829 [details]
follow-up patch

rs=maciej
Comment 7 Geoffrey Garen 2011-01-22 10:54:30 PST
Created attachment 79849 [details]
Patch
Comment 8 Geoffrey Garen 2011-01-22 10:57:47 PST
Addressing another set of review comments.
Comment 9 Geoffrey Garen 2011-01-22 10:59:20 PST
Created attachment 79850 [details]
Patch
Comment 10 Geoffrey Garen 2011-01-22 12:10:39 PST
Comment on attachment 79850 [details]
Patch

rs=maciej
Comment 11 Geoffrey Garen 2011-01-22 12:11:35 PST
Committed r76454: <http://trac.webkit.org/changeset/76454>