Bug 52914

Summary: Web Inspector: [Chromium] Heap snapshot table sorting is broken
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch pfeldman: review+

Mikhail Naganov
Reported 2011-01-21 13:01:20 PST
From http://code.google.com/p/chromium/issues/detail?id=70436: Chrome Version : 9.0.597.67 (Official Build 71393) beta What steps will reproduce the problem? 1. Create a heap snapshot 2. Click on the Constructor column header What is the expected result? Table sorts alphabetically by constructor name. What happens instead? The first row randomly switches position with another row. Please provide any additional information below. Attach a screenshot if possible. This same problem happens when trying to sort on the ±Count column when all counts are 0.
Attachments
patch (3.04 KB, patch)
2011-01-21 13:23 PST, Mikhail Naganov
pfeldman: review+
Mikhail Naganov
Comment 1 2011-01-21 13:23:26 PST
Mikhail Naganov
Comment 2 2011-01-24 06:41:04 PST
Manually committed http://trac.webkit.org/changeset/76514: 2011-01-21 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: [Chromium] Fix heap snapshot table sorting. Fix table sorting to avoid qsort instability artefacts. https://bugs.webkit.org/show_bug.cgi?id=52914 * inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):
WebKit Review Bot
Comment 3 2011-01-24 08:46:40 PST
http://trac.webkit.org/changeset/76514 might have broken GTK Linux 32-bit Debug The following tests are not passing: editing/selection/extend-selection-bidi.html
Note You need to log in before you can comment on or make changes to this bug.