Summary: | Web Inspector: size is wrong for cached resources in Network panel | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-01-21 04:47:18 PST
Created attachment 80075 [details]
patch
Comment on attachment 80075 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=80075&action=review > Source/WebCore/inspector/Inspector.idl:110 > + [notify, domain=Network] void didReceiveResponse(out long identifier, out double time, out String resourceType, out long cachedSize, out Object response); didReceiveResponse should not special-case cached resources. It would be better to call didReceiveContentLength for cached resources instead. > Source/WebCore/inspector/front-end/NetworkManager.js:179 > + if (resource.revalidated) This would go away. > Source/WebCore/inspector/front-end/Resource.js:241 > + var size = this.cached || this.revalidated ? 0 : Number(this.resourceSize || this.responseHeaders["Content-Length"] || 0); Could you replace ternary operators with guards for ease of understanding? > Source/WebCore/inspector/front-end/Resource.js:309 > + get revalidated() get statusIsNotModified? Created attachment 80181 [details]
patch
Removed additional resource size parameter to didReceiveResponse, issue additional call to didReceiveContentLength in case we got 304 and had a cached resource.
Comment on attachment 80181 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=80181&action=review > Source/WebCore/inspector/front-end/Resource.js:245 > + var bodySize = Number(this.resourceSize || this.responseHeaders["Content-Length"] || 0); In what cases do we use Content-Length header Is it more accurate? Was is used for gzip? http://trac.webkit.org/changeset/76690 might have broken Leopard Intel Release (Tests) Manually committed r76690: http://trac.webkit.org/changeset/76690 |